| commit | 2fd673ecf0378ddeeeb87b3605e50212e0c0ddc6 | |
| author | Tejun Heo <tj@kernel.org> | |
| Fri, 29 Aug 2008 14:13:12 +0000 (29 16:13 +0200) | ||
| committer | Jeff Garzik <jgarzik@redhat.com> | |
| Mon, 8 Sep 2008 16:15:35 +0000 (8 12:15 -0400) | ||
| tree | 92cbd1a87d3ba82d52494ca204fe34d09aa4c79a | treesnapshot (tar.gz zip) |
| parent | 17248461cb66103b87ff03bdee34aa61035cc93e | commitdiff |
sata_nv: disable hardreset for generic
of them being unifying probing, hotplug and EH reset paths uniform.
Previously, broken hardreset could go unnoticed as it wasn't used
during probing but when something goes wrong or after hotplug the
problem will surface and bite hard.
OSDL bug 11195 reports that sata_nv generic flavor falls into this
category. Hardreset itself succeeds but PHY stays offline after
hardreset. I tried longer debounce timing but the result was the
same.
http://bugzilla.kernel.org/show_bug.cgi?id=11195
So, it seems we'll have to drop hardreset from the generic flavor.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Peer Chen <pchen@nvidia.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
of them being unifying probing, hotplug and EH reset paths uniform.
Previously, broken hardreset could go unnoticed as it wasn't used
during probing but when something goes wrong or after hotplug the
problem will surface and bite hard.
OSDL bug 11195 reports that sata_nv generic flavor falls into this
category. Hardreset itself succeeds but PHY stays offline after
hardreset. I tried longer debounce timing but the result was the
same.
http://bugzilla.kernel.org/show_bug.cgi?id=11195
So, it seems we'll have to drop hardreset from the generic flavor.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Peer Chen <pchen@nvidia.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
| drivers/ata/sata_nv.c | diffblobblamehistory |