| commit | 25cef2251415cef5438e20965fec87096fe2efb0 | |
| author | Uwe Kleine-König <ukleinek@strlen.de> | |
| Wed, 8 Oct 2008 07:01:39 +0000 (8 10:01 +0300) | ||
| committer | Tony Lindgren <tony@atomide.com> | |
| Wed, 8 Oct 2008 07:01:39 +0000 (8 10:01 +0300) | ||
| tree | 8f3de286d8c8d4a57f2cc04b036bd3f3680bb026 | treesnapshot (tar.gz zip) |
| parent | 56f68556d7bbb51dd158c74deb09c783345bfbbd | commitdiff |
Fix sections for omap-mcbsp platform driver
Don't use __init but __devinit to define probe function. A pointer to
omap_mcbsp_probe is passed to the core via platform_driver_register and
so the function must not disappear when the init code is freed. Using
__init and having HOTPLUG=y the following probably oopses:
echo -n omap-mcbsp.1 > /sys/bus/platform/driver/omap-mcbsp/unbind
echo -n omap-mcbsp.1 > /sys/bus/platform/driver/omap-mcbsp/bind
While at it move the remove function to the .devexit.text section.
Signed-off-by: Uwe Kleine-König <ukleinek@strlen.de>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Don't use __init but __devinit to define probe function. A pointer to
omap_mcbsp_probe is passed to the core via platform_driver_register and
so the function must not disappear when the init code is freed. Using
__init and having HOTPLUG=y the following probably oopses:
echo -n omap-mcbsp.1 > /sys/bus/platform/driver/omap-mcbsp/unbind
echo -n omap-mcbsp.1 > /sys/bus/platform/driver/omap-mcbsp/bind
While at it move the remove function to the .devexit.text section.
Signed-off-by: Uwe Kleine-König <ukleinek@strlen.de>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Tony Lindgren <tony@atomide.com>
| arch/arm/plat-omap/mcbsp.c | diffblobblamehistory |