| commit | 23d1f7ce08dfc77a0e8cdf0ade18df0c1505d0de | |
| author | Andrew Morton <akpm@linux-foundation.org> | |
| Tue, 26 Oct 2010 21:21:19 +0000 (26 14:21 -0700) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Thu, 9 Dec 2010 21:32:29 +0000 (9 13:32 -0800) | ||
| tree | 0d396b781d85cb28b0eb626fe164eb28e68a0407 | treesnapshot (tar.gz zip) |
| parent | c370b6230721a11a0f0ee72d0cce71c0e0082175 | commitdiff |
kfifo: disable __kfifo_must_check_helper()
commit 52c5171214ff3327961d0ce0db7e8d2ce55004fd upstream.
This helper is wrong: it coerces signed values into unsigned ones, so code
such as
if (kfifo_alloc(...) < 0) {
error
}
will fail to detect the error.
So let's disable __kfifo_must_check_helper() for 2.6.36.
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stefani Seibold <stefani@seibold.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit 52c5171214ff3327961d0ce0db7e8d2ce55004fd upstream.
This helper is wrong: it coerces signed values into unsigned ones, so code
such as
if (kfifo_alloc(...) < 0) {
error
}
will fail to detect the error.
So let's disable __kfifo_must_check_helper() for 2.6.36.
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stefani Seibold <stefani@seibold.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| include/linux/kfifo.h | diffblobblamehistory |