cfq-iosched: fix locking around ioc->ioc_data assignment
commit1ff36a0e02f978e533b13ce6a86ad6a73444cec8
authorJens Axboe <jaxboe@fusionio.com>
Sun, 5 Jun 2011 04:01:13 +0000 (5 06:01 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 13 Jul 2011 03:29:24 +0000 (13 05:29 +0200)
treef51ea39985a7b77710aae2552a4df1204c10a90e
parent336fca97910371e16506e5448ad0ca9daae9a59c
cfq-iosched: fix locking around ioc->ioc_data assignment

commit ab4bd22d3cce6977dc039664cc2d052e3147d662 upstream.

Since we are modifying this RCU pointer, we need to hold
the lock protecting it around it.

This fixes a potential reuse and double free of a cfq
io_context structure. The bug has been in CFQ for a long
time, it hit very few people but those it did hit seemed
to see it a lot.

Tracked in RH bugzilla here:

https://bugzilla.redhat.com/show_bug.cgi?id=577968

Credit goes to Paul Bolle for figuring out that the issue
was around the one-hit ioc->ioc_data cache. Thanks to his
hard work the issue is now fixed.

Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
block/cfq-iosched.c