| commit | 1af4791552e462b37d0174407dc3173917e35ea0 | |
| author | Marcin Slusarz <marcin.slusarz@gmail.com> | |
| Sun, 20 Feb 2011 19:03:34 +0000 (20 20:03 +0100) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Wed, 23 Feb 2011 22:39:09 +0000 (23 14:39 -0800) | ||
| tree | c103a4a5db1bf72e7854abb72e1e1ddc5115e2ad | treesnapshot (tar.gz zip) |
| parent | 3f60554cb121b951d250639b01c828cf41aa09da | commitdiff |
staging/et131x: fix et131x_rx_dma_disable halt_status usage
Commit 1bd751c1abc1029e8a0ae63ef4f19357c735a2a3
("Staging: et131x: Clean up rxdma_csr") changed csr from bitfield to
u32, but failed to convert 2 uses of halt_status bit. It did:
- if (csr.bits.halt_status != 1)
+ if ((csr & 0x00020000) != 1)
which is wrong, because second version is always true.
Fix it.
This bug was found by coccinelle (http://coccinelle.lip6.fr/).
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Commit 1bd751c1abc1029e8a0ae63ef4f19357c735a2a3
("Staging: et131x: Clean up rxdma_csr") changed csr from bitfield to
u32, but failed to convert 2 uses of halt_status bit. It did:
- if (csr.bits.halt_status != 1)
+ if ((csr & 0x00020000) != 1)
which is wrong, because second version is always true.
Fix it.
This bug was found by coccinelle (http://coccinelle.lip6.fr/).
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/staging/et131x/et1310_rx.c | diffblobblamehistory |