| commit | 1584b89c921acefe88881f08d836d80f00600a84 | |
| author | Andi Kleen <ak@suse.de> | |
| Wed, 11 Jan 2006 21:43:42 +0000 (11 22:43 +0100) | ||
| committer | Linus Torvalds <torvalds@g5.osdl.org> | |
| Thu, 12 Jan 2006 03:04:51 +0000 (11 19:04 -0800) | ||
| tree | 112d64a284488f490045b19aa910bb1b2abcbff4 | treesnapshot (tar.gz zip) |
| parent | 7a4a76cc1057de0dc96ee481590347aa8c5b9ffb | commitdiff |
[PATCH] x86_64: Validate SLIT table
A lot of Opteron BIOS just pass 10 in all SLIT entries (10 is the
normalized unit). This is actually worse than the default heuristic
because it leads to pci_distance not knowing the difference between
local and remote nodes anymore. This messes up some NUMA
heuristics in generic code.
In this case it's better to fall back to the default heuristic
which just does nodea == nodeb ? 10 : 20.
This patch does some basic sanity checking on the SLIT and only accepts
the SLIT when it passes.
Invariants enforced are:
- Node to itself shall be 10
- Any other distance shouldn't be 10
- Distances smaller than 10 are illegal
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
A lot of Opteron BIOS just pass 10 in all SLIT entries (10 is the
normalized unit). This is actually worse than the default heuristic
because it leads to pci_distance not knowing the difference between
local and remote nodes anymore. This messes up some NUMA
heuristics in generic code.
In this case it's better to fall back to the default heuristic
which just does nodea == nodeb ? 10 : 20.
This patch does some basic sanity checking on the SLIT and only accepts
the SLIT when it passes.
Invariants enforced are:
- Node to itself shall be 10
- Any other distance shouldn't be 10
- Distances smaller than 10 are illegal
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| arch/x86_64/mm/srat.c | diffblobblamehistory |