USB: ehci: remove structure packing from ehci_def
commit139540170d9d9b7ead3caaf540f161756b356d56
authorRabin Vincent <rabin@rab.in>
Wed, 27 Apr 2011 15:37:28 +0000 (27 21:07 +0530)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 3 May 2011 17:09:32 +0000 (3 10:09 -0700)
tree2c7f5eca86ac5d475438a80bc427d63bbd6dd341
parent14be249c969817e05c4f1ce042906e1c5be68873
USB: ehci: remove structure packing from ehci_def

As pointed out by Arnd Bergmann, in include/linux/usb/ehci_def.h, struct
ehci_caps is defined with __attribute__((packed)) for no good reason,
and this triggers undefined behaviour when using ARM's readl() on
pointers to elements of this structure:

http://lkml.kernel.org/r/201102021700.20683.arnd@arndb.de

The same problem exists with the other two structures in ehci_def.h too,
so remove the __attribute__((packed)) from all of them.

Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Rabin Vincent <rabin@rab.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
include/linux/usb/ehci_def.h