| commit | 12cdd3d71954c2cd6dd556eec25dd7d346735831 | |
| author | Nicolas Kaiser <nikai@nikai.net> | |
| Mon, 15 Nov 2010 18:40:28 +0000 (15 19:40 +0100) | ||
| committer | Kevin Hilman <khilman@deeprootsystems.com> | |
| Fri, 10 Dec 2010 15:33:51 +0000 (10 07:33 -0800) | ||
| tree | 2201eb4a1fea43603ef527321a8a7a83c46d7c67 | treesnapshot (tar.gz zip) |
| parent | 1a07bfb5215e11227403f121097ed72187dc3241 | commitdiff |
davinci: aemif: signedness bug in davinci_aemif_setup_timing()
aemif_calc_rate() can return a negative error value, so all the
variables that get tested for this value need to be signed.
The maximum bit width of WSETUP(WSETUP_MAX) appears to be 30 bits
(0xf << 26). Using a signed instead of an unsigned integer
shouldn't make a difference here.
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
Acked-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
aemif_calc_rate() can return a negative error value, so all the
variables that get tested for this value need to be signed.
The maximum bit width of WSETUP(WSETUP_MAX) appears to be 30 bits
(0xf << 26). Using a signed instead of an unsigned integer
shouldn't make a difference here.
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
Acked-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
| arch/arm/mach-davinci/aemif.c | diffblobblamehistory |