| commit | 10e7454ed7a2da39f1f6255f63d7df27ab4bb67f | |
| author | Herbert Xu <herbert@gondor.apana.org.au> | |
| Mon, 15 Feb 2010 19:24:30 +0000 (15 19:24 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Tue, 16 Feb 2010 22:53:24 +0000 (16 14:53 -0800) | ||
| tree | 467bf2ee42e91914ac679ad871a87ea2ecb3925f | treesnapshot (tar.gz zip) |
| parent | 1cab819b5e244e1b853c7b440981e6a960da3bfb | commitdiff |
ipcomp: Avoid duplicate calls to ipcomp_destroy
When ipcomp_tunnel_attach fails we will call ipcomp_destroy twice.
This may lead to double-frees on certain structures.
As there is no reason to explicitly call ipcomp_destroy, this patch
removes it from ipcomp*.c and lets the standard xfrm_state destruction
take place.
This is based on the discovery and patch by Alexey Dobriyan.
Tested-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
When ipcomp_tunnel_attach fails we will call ipcomp_destroy twice.
This may lead to double-frees on certain structures.
As there is no reason to explicitly call ipcomp_destroy, this patch
removes it from ipcomp*.c and lets the standard xfrm_state destruction
take place.
This is based on the discovery and patch by Alexey Dobriyan.
Tested-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
| net/ipv4/ipcomp.c | diffblobblamehistory | |
| net/ipv6/ipcomp6.c | diffblobblamehistory |