| commit | 0ca4b6b00113b064c080d26d803d0d7c80fb5dc8 | |
| author | Matthew Wilcox <matthew@wil.cx> | |
| Thu, 20 Nov 2008 21:09:33 +0000 (20 14:09 -0700) | ||
| committer | Linus Torvalds <torvalds@linux-foundation.org> | |
| Thu, 20 Nov 2008 21:17:40 +0000 (20 13:17 -0800) | ||
| tree | 69e25f61bf252f2db0c0d01244555f90ad48aaf1 | treesnapshot (tar.gz zip) |
| parent | 23918b03060f6e572168fdde1798a905679d2e06 | commitdiff |
x86: Fix interrupt leak due to migration
When we migrate an interrupt from one CPU to another, we set the
move_in_progress flag and clean up the vectors later once they're not
being used. If you're unlucky and call destroy_irq() before the vectors
become un-used, the move_in_progress flag is never cleared, which causes
the interrupt to become unusable.
This was discovered by Jesse Brandeburg for whom it manifested as an
MSI-X device refusing to use MSI-X mode when the driver was unloaded
and reloaded repeatedly.
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
When we migrate an interrupt from one CPU to another, we set the
move_in_progress flag and clean up the vectors later once they're not
being used. If you're unlucky and call destroy_irq() before the vectors
become un-used, the move_in_progress flag is never cleared, which causes
the interrupt to become unusable.
This was discovered by Jesse Brandeburg for whom it manifested as an
MSI-X device refusing to use MSI-X mode when the driver was unloaded
and reloaded repeatedly.
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| arch/x86/kernel/io_apic.c | diffblobblamehistory |