| commit | 0c61227094b3ddaca2f847ee287c4a2e3762b5a2 | |
| author | Gleb Natapov <gleb@redhat.com> | |
| Tue, 26 Apr 2011 08:21:32 +0000 (26 11:21 +0300) | ||
| committer | H. Peter Anvin <hpa@linux.intel.com> | |
| Wed, 27 Apr 2011 21:16:12 +0000 (27 14:16 -0700) | ||
| tree | b9575437608041e1ebce1302ce1fb20902a04656 | treesnapshot (tar.gz zip) |
| parent | 8e10cd74342c7f5ce259cceca36f6eba084f5d58 | commitdiff |
x86, setup: Fix EDD3.0 data verification.
Check for nonzero path in edd_has_edd30() has no sense. First, it looks
at the wrong memory. Device path starts at offset 30 of the info->params
structure which is at offset 8 from the beginning of info structure,
but code looks at info + 4 instead. This was correct when code was
introduced, but around v2.6.4 three more fields were added to edd_info
structure (commit 66b61a5c in history.git). Second, even if it will check
correct memory it will always succeed since at offset 30 (params->key)
there will be non-zero values otherwise previous check would fail.
The patch replaces this bogus check with one that verifies checksum.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
Link: http://lkml.kernel.org/r/20110426082132.GG2265@redhat.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Check for nonzero path in edd_has_edd30() has no sense. First, it looks
at the wrong memory. Device path starts at offset 30 of the info->params
structure which is at offset 8 from the beginning of info structure,
but code looks at info + 4 instead. This was correct when code was
introduced, but around v2.6.4 three more fields were added to edd_info
structure (commit 66b61a5c in history.git). Second, even if it will check
correct memory it will always succeed since at offset 30 (params->key)
there will be non-zero values otherwise previous check would fail.
The patch replaces this bogus check with one that verifies checksum.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
Link: http://lkml.kernel.org/r/20110426082132.GG2265@redhat.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
| drivers/firmware/edd.c | diffblobblamehistory |