| commit | 0376d5b25ef11e9b6450ebae20781a32d8985170 | |
| author | Julia Lawall <julia@diku.dk> | |
| Sun, 19 Jul 2009 05:26:35 +0000 (19 05:26 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Tue, 21 Jul 2009 20:00:44 +0000 (21 13:00 -0700) | ||
| tree | 9b10003556025267385341ec8c6b98dca44e833c | treesnapshot (tar.gz zip) |
| parent | 0021195c40326ac4702faf28c32accd91b331641 | commitdiff |
drivers/net: Move a dereference below a NULL test
If the NULL test is necessary, then the dereference should be moved below
the NULL test.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
expression E,E1;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E=E1
when != i
if (E == NULL||...) S
+ i = E->fld;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
If the NULL test is necessary, then the dereference should be moved below
the NULL test.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
expression E,E1;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E=E1
when != i
if (E == NULL||...) S
+ i = E->fld;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/bnx2x_link.c | diffblobblamehistory |