| commit | d68b8622ccbee8a18e495ad1650c3306f2eeb0d6 | |
| author | Roland McGrath <roland@redhat.com> | |
| Thu, 26 May 2005 22:21:13 +0000 (26 15:21 -0700) | ||
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | |
| Thu, 26 May 2005 23:16:16 +0000 (26 16:16 -0700) | ||
| tree | 7ec334394d78055de4d085c354c2931390c229f0 | treesnapshot (tar.gz zip) |
| parent | 4ec5240ec367a592834385893200dd4fb369354c | commitdiff |
[PATCH] i386: fix prevent_tail_call
We fixed this bug before, but it didn't take. It may have been the case
that the problem was first noticed to occur in a CONFIG_REGPARM compile.
But it's not regparm functions that need not to make tail calls, it's
asmlinkage functions called with a user pt_regs frame on the stack
supplying their arguments. prevent_tail_call probably doesn't do anything
at all in regparm functions (your argument registers are going to be
clobbered, period). It was a braino to conditionalize that definition in
the first place.
Signed-off-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
We fixed this bug before, but it didn't take. It may have been the case
that the problem was first noticed to occur in a CONFIG_REGPARM compile.
But it's not regparm functions that need not to make tail calls, it's
asmlinkage functions called with a user pt_regs frame on the stack
supplying their arguments. prevent_tail_call probably doesn't do anything
at all in regparm functions (your argument registers are going to be
clobbered, period). It was a braino to conditionalize that definition in
the first place.
Signed-off-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| include/asm-i386/linkage.h | diffblobblamehistory |