USB: cdc-acm: signedness fix
commitc6dbf554bc8a79c9caab3dbf891a33c19068f646
authorDavid Brownell <david-b@pacbell.net>
Sun, 13 Apr 2008 21:00:44 +0000 (13 14:00 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 25 Apr 2008 04:16:53 +0000 (24 21:16 -0700)
treebe47ae8d24aa2564fd424fecc1ef85e6717dd06d
parent08177e12b7b4c3d59060f829e5c151d06f9a08d6
USB: cdc-acm: signedness fix

Fix bogus assignment of "unsigned char *" to "char *":  preserve
unsignedness.  These values are used directly as descriptor lengths
when iterating through the buffer, so this *could* cause oddness
that potentially includes oopsing.  (IMO not likely, except as
part of a malicious device...)

Fix the bogus warning in CDC ACM which highlighted this problem
(by showing a negative descriptor type).  It uses the undesirable
legacy err() for something that's not even an error; switch to
use dev_dbg, and show descriptor types in hex notation to match
the convention for such codes.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Acked-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/class/cdc-acm.c