| commit | 7e85ee0c1d15ca5f8bff0f514f158eba1742dd87 | |
| author | Pekka Enberg <penberg@cs.helsinki.fi> | |
| Fri, 12 Jun 2009 11:03:06 +0000 (12 14:03 +0300) | ||
| committer | Pekka Enberg <penberg@cs.helsinki.fi> | |
| Fri, 12 Jun 2009 15:53:33 +0000 (12 18:53 +0300) | ||
| tree | 8f9c21f0df6bea88740d7dd48834ac9ffc238e93 | treesnapshot (tar.gz zip) |
| parent | eb91f1d0a531289e18f5587dc197d12a251c66a3 | commitdiff |
slab,slub: don't enable interrupts during early boot
As explained by Benjamin Herrenschmidt:
Oh and btw, your patch alone doesn't fix powerpc, because it's missing
a whole bunch of GFP_KERNEL's in the arch code... You would have to
grep the entire kernel for things that check slab_is_available() and
even then you'll be missing some.
For example, slab_is_available() didn't always exist, and so in the
early days on powerpc, we used a mem_init_done global that is set form
mem_init() (not perfect but works in practice). And we still have code
using that to do the test.
Therefore, mask out __GFP_WAIT, __GFP_IO, and __GFP_FS in the slab allocators
in early boot code to avoid enabling interrupts.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
As explained by Benjamin Herrenschmidt:
Oh and btw, your patch alone doesn't fix powerpc, because it's missing
a whole bunch of GFP_KERNEL's in the arch code... You would have to
grep the entire kernel for things that check slab_is_available() and
even then you'll be missing some.
For example, slab_is_available() didn't always exist, and so in the
early days on powerpc, we used a mem_init_done global that is set form
mem_init() (not perfect but works in practice). And we still have code
using that to do the test.
Therefore, mask out __GFP_WAIT, __GFP_IO, and __GFP_FS in the slab allocators
in early boot code to avoid enabling interrupts.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>