| commit | 04321587584272f4e8b9818f319f40caf8eeee13 | |
| author | Rusty Russell <rusty@rustcorp.com.au> | |
| Mon, 28 Jul 2008 17:16:29 +0000 (28 12:16 -0500) | ||
| committer | Rusty Russell <rusty@rustcorp.com.au> | |
| Mon, 28 Jul 2008 02:16:29 +0000 (28 12:16 +1000) | ||
| tree | 5bf00c36a182644cc2c4fe2577b14e050a49418b | treesnapshot (tar.gz zip) |
| parent | ffdb5976c47609c862917d4c186ecbb5706d2dda | commitdiff |
Hotplug CPU: don't check cpu_online after take_cpu_down
Akinobu points out that if take_cpu_down() succeeds, the cpu must be offline.
Remove the cpu_online() check, and put a BUG_ON().
Quoting Akinobu Mita:
Actually the cpu_online() check was necessary before appling this
stop_machine: simplify patch.
With old __stop_machine_run(), __stop_machine_run() could succeed
(return !IS_ERR(p) value) even if take_cpu_down() returned non-zero value.
The return value of take_cpu_down() was obtained through kthread_stop()..
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Akinobu Mita" <akinobu.mita@gmail.com>
Akinobu points out that if take_cpu_down() succeeds, the cpu must be offline.
Remove the cpu_online() check, and put a BUG_ON().
Quoting Akinobu Mita:
Actually the cpu_online() check was necessary before appling this
stop_machine: simplify patch.
With old __stop_machine_run(), __stop_machine_run() could succeed
(return !IS_ERR(p) value) even if take_cpu_down() returned non-zero value.
The return value of take_cpu_down() was obtained through kthread_stop()..
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Akinobu Mita" <akinobu.mita@gmail.com>
| kernel/cpu.c | diffblobblamehistory |