uml: network interface hotplug error handling
commitf34d9d2dcb7f17b64124841345b23adc0843e7a5
authorJeff Dike <jdike@addtoit.com>
Sun, 6 May 2007 21:51:04 +0000 (6 14:51 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Mon, 7 May 2007 19:13:00 +0000 (7 12:13 -0700)
tree0bb200273bcc37da8dd32945ae25c213c9efe2c2
parentb16895b63c504698b0c3ab26ca3c41a4fa162a42
uml: network interface hotplug error handling

This fixes a number of problems associated with network interface hotplug.

The userspace initialization function can fail in some cases, but the
failure was never passed back to eth_configure, which proceeded with the
configuration.  This results in a zombie device that is present, but can't
work.  This is fixed by allowing the initialization routines to return an
error, which is checked, and the configuration aborted on failure.

eth_configure failed to check for many failures.  Even when it did check,
it didn't undo whatever initializations has already happened, so a present,
but partially initialized and non-working device could result.  It now
checks everything that can fail, and bails out, undoing whatever had been
done.

The return value of eth_configure was always ignored, so it is now just
void.

Signed-off-by: Jeff Dike <jdike@linux.intel.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/um/drivers/daemon_user.c
arch/um/drivers/mcast_user.c
arch/um/drivers/net_kern.c
arch/um/drivers/pcap_user.c
arch/um/drivers/slip_user.c
arch/um/drivers/slirp_user.c
arch/um/include/net_user.h
arch/um/os-Linux/drivers/ethertap_user.c
arch/um/os-Linux/drivers/tuntap_user.c