| commit | d46203159ed376fdbe2b05aa57e58207bf27a8f9 | |
| author | Robin Dong <hao.bigrat@gmail.com> | |
| Mon, 18 Jul 2011 03:43:42 +0000 (17 23:43 -0400) | ||
| committer | Theodore Ts'o <tytso@mit.edu> | |
| Mon, 18 Jul 2011 03:43:42 +0000 (17 23:43 -0400) | ||
| tree | 8bcbe5545066606b12d6cd250747471802520c0b | treesnapshot (tar.gz zip) |
| parent | 015861badd0db43d025bbb538f8fc62dfaf3f18d | commitdiff |
ext4: avoid eh_entries overflow before insert extent_idx
If eh_entries is equal to (or greater than) eh_max, the operation of
inserting new extent_idx will make number of entries overflow.
So check eh_entries before inserting the new extent_idx.
Although there is no bug case according the code (function
ext4_ext_insert_index is called by ext4_ext_split and ext4_ext_split
is called only if the index block has free space), the right logic
should be "lookup the capacity before insertion".
Signed-off-by: Robin Dong <sanbai@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
If eh_entries is equal to (or greater than) eh_max, the operation of
inserting new extent_idx will make number of entries overflow.
So check eh_entries before inserting the new extent_idx.
Although there is no bug case according the code (function
ext4_ext_insert_index is called by ext4_ext_split and ext4_ext_split
is called only if the index block has free space), the right logic
should be "lookup the capacity before insertion".
Signed-off-by: Robin Dong <sanbai@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
| fs/ext4/extents.c | diffblobblamehistory |