| commit | caaf7a29d31da21bb8d8200d5e42d1c93d3c6e00 | |
| author | Tao Ma <boyu.mt@taobao.com> | |
| Mon, 11 Jul 2011 22:42:42 +0000 (11 18:42 -0400) | ||
| committer | Theodore Ts'o <tytso@mit.edu> | |
| Mon, 11 Jul 2011 22:42:42 +0000 (11 18:42 -0400) | ||
| tree | 880f1cd67f0a8c1fb1dfbb1359358d930b0f611a | treesnapshot (tar.gz zip) |
| parent | 823ba01fc07751200c43e45733925a98b73eac3a | commitdiff |
ext4: Fix a double free of sbi->s_group_info in ext4_mb_init_backend
If we meet with an error in ext4_mb_add_groupinfo, we kfree
sbi->s_group_info[group >> EXT4_DESC_PER_BLOCK_BITS(sb)], but fail to
reset it to NULL. So the caller ext4_mb_init_backend will try to kfree
it again and causes a double free. So fix it by resetting it to NULL.
Some typo in comments of mballoc.c are also changed.
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
If we meet with an error in ext4_mb_add_groupinfo, we kfree
sbi->s_group_info[group >> EXT4_DESC_PER_BLOCK_BITS(sb)], but fail to
reset it to NULL. So the caller ext4_mb_init_backend will try to kfree
it again and causes a double free. So fix it by resetting it to NULL.
Some typo in comments of mballoc.c are also changed.
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
| fs/ext4/mballoc.c | diffblobblamehistory |