ipvs: flush defense_work before module unload
commitc214b2cc5f9be7c236f9b91acf524688ff0e3e72
authorOleg Nesterov <oleg@tv-sign.ru>
Wed, 9 May 2007 09:34:18 +0000 (9 02:34 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Wed, 9 May 2007 19:30:52 +0000 (9 12:30 -0700)
tree9edffda8f78422d01219dacf9ab2fb0104302a1d
parent1634c48f8b85dcb05101f1eb2eab9af40b5976da
ipvs: flush defense_work before module unload

net/ipv4/ipvs/ip_vs_core.c

module_exit
    ip_vs_cleanup
ip_vs_control_cleanup
    cancel_rearming_delayed_work
// done

This is unsafe.  The module may be unloaded and the memory may be freed
while defense_work's handler is still running/preempted.

Do flush_work(&defense_work.work) after cancel_rearming_delayed_work().

Alternatively, we could add flush_work() to cancel_rearming_delayed_work(),
but note that we can't change cancel_delayed_work() in the same manner
because it may be called from atomic context.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
net/ipv4/ipvs/ip_vs_ctl.c