[SCSI] scsi_debug: Fix off-by-one bug when unmapping region
commitbc977749e967daa56de1922cf4cb38525631c51c
authorLukas Czerner <lczerner@redhat.com>
Thu, 16 Aug 2012 14:38:45 +0000 (16 16:38 +0200)
committerJames Bottomley <JBottomley@Parallels.com>
Tue, 9 Oct 2012 11:23:11 +0000 (9 12:23 +0100)
tree8a601ff599a503f68377b4ea77c49cad54ca24e3
parent329a402cb052b233bc92aa34c4caf2f7dfb2d76e
[SCSI] scsi_debug: Fix off-by-one bug when unmapping region

Currently it is possible to unmap one more block than user requested to
due to the off-by-one error in unmap_region(). This is probably due to
the fact that the end variable despite its name actually points to the
last block to unmap + 1. However in the condition it is handled as the
last block of the region to unmap.

The bug was not previously spotted probably due to the fact that the
region was not zeroed, which has changed with commit
be1dd78de5686c062bb3103f9e86d444a10ed783. With that commit we were able
to corrupt the ext4 file system on 256M scsi_debug device with LBPRZ
enabled using fstrim.

Since the 'end' semantic is the same in several functions there this
commit just fixes the condition to use the 'end' variable correctly in
that context.

Reported-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/scsi_debug.c