cfg80211: disallow bridging managed/adhoc interfaces
commitad4bb6f8883a13bb0f65b194dae36c62a02ac779
authorJohannes Berg <johannes@sipsolutions.net>
Wed, 18 Nov 2009 23:56:30 +0000 (19 00:56 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 19 Nov 2009 16:08:54 +0000 (19 11:08 -0500)
treeb395936203ac891b9a537c26b4602f727c4387d0
parent9bc383de37090ba7ca3ff32a12c9d809dc5867f0
cfg80211: disallow bridging managed/adhoc interfaces

A number of people have tried to add a wireless interface
(in managed mode) to a bridge and then complained that it
doesn't work. It cannot work, however, because in 802.11
networks all packets need to be acknowledged and as such
need to be sent to the right address. Promiscuous doesn't
help here. The wireless address format used for these
links has only space for three addresses, the
 * transmitter, which must be equal to the sender (origin)
 * receiver (on the wireless medium), which is the AP in
   the case of managed mode
 * the recipient (destination), which is on the APs local
   network segment

In an IBSS, it is similar, but the receiver and recipient
must match and the third address is used as the BSSID.

To avoid such mistakes in the future, disallow adding a
wireless interface to a bridge.

Felix has recently added a four-address mode to the AP
and client side that can be used (after negotiating that
it is possible, which must happen out-of-band by setting
up both sides) for bridging, so allow that case.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
include/linux/if.h
net/bridge/br_if.c
net/wireless/core.c
net/wireless/nl80211.c
net/wireless/util.c