| commit | 49f3eacfcdab2e1cd381dc8e820bb6840787be00 | |
| author | Mark Brown <broonie@opensource.wolfsonmicro.com> | |
| Thu, 19 Jul 2012 05:36:13 +0000 (19 14:36 +0900) | ||
| committer | Kukjin Kim <kgene.kim@samsung.com> | |
| Thu, 19 Jul 2012 05:36:13 +0000 (19 14:36 +0900) | ||
| tree | c54f314c09e604ec091c383926c8b0f3de97e34a | treesnapshot (tar.gz zip) |
| parent | f9ed561ebd71f7a9a3238507ef9082862e2cbc9a | commitdiff |
spi/s3c64xx: Fix handling of errors in gpio_request()
When gpio_request() fails the driver logged the failure but while it'd
try to print an error code in the non-DT case it didn't pass the error
code in so garbage would be logged and in the DT case the error wasn't
logged.
Further, in the non-DT case the error code was then overwritten with -EBUSY
depriving the caller of information and breaking automatic probe deferral
pushing back from the GPIO level. Also reformat the non-DT log message
so it's not word wrapped and we can grep for it.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
When gpio_request() fails the driver logged the failure but while it'd
try to print an error code in the non-DT case it didn't pass the error
code in so garbage would be logged and in the DT case the error wasn't
logged.
Further, in the non-DT case the error code was then overwritten with -EBUSY
depriving the caller of information and breaking automatic probe deferral
pushing back from the GPIO level. Also reformat the non-DT log message
so it's not word wrapped and we can grep for it.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
| drivers/spi/spi-s3c64xx.c | diffblobblamehistory |