| commit | 168bfeef7bba3f9784f7540b053e4ac72b769ce9 | |
| author | Andrew Morton <akpm@linux-foundation.org> | |
| Tue, 23 Oct 2012 21:09:39 +0000 (23 14:09 -0700) | ||
| committer | Borislav Petkov <borislav.petkov@amd.com> | |
| Wed, 24 Oct 2012 14:13:27 +0000 (24 16:13 +0200) | ||
| tree | a02890616eb3d65377be628ff9cd1b577beb36df | treesnapshot (tar.gz zip) |
| parent | 6f0c0580b70c89094b3422ba81118c7b959c7556 | commitdiff |
amd64_edac:__amd64_set_scrub_rate(): avoid overindexing scrubrates[]
If none of the elements in scrubrates[] matches, this loop will cause
__amd64_set_scrub_rate() to incorrectly use the n+1th element.
As the function is designed to use the final scrubrates[] element in the
case of no match, we can fix this bug by simply terminating the array
search at the n-1th element.
Boris: this code is fragile anyway, see here why:
http://marc.info/?l=linux-kernel&m=135102834131236&w=2
It will be rewritten more robustly soonish.
Reported-by: Denis Kirjanov <kirjanov@gmail.com>
Cc: stable@vger.kernel.org
Cc: Doug Thompson <dougthompson@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
If none of the elements in scrubrates[] matches, this loop will cause
__amd64_set_scrub_rate() to incorrectly use the n+1th element.
As the function is designed to use the final scrubrates[] element in the
case of no match, we can fix this bug by simply terminating the array
search at the n-1th element.
Boris: this code is fragile anyway, see here why:
http://marc.info/?l=linux-kernel&m=135102834131236&w=2
It will be rewritten more robustly soonish.
Reported-by: Denis Kirjanov <kirjanov@gmail.com>
Cc: stable@vger.kernel.org
Cc: Doug Thompson <dougthompson@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
| drivers/edac/amd64_edac.c | diffblobblamehistory |