From 40e5c96b229928b28edd99cdb981ff5e74938d19 Mon Sep 17 00:00:00 2001 From: Brett Rudley Date: Fri, 8 Oct 2010 13:57:13 -0700 Subject: [PATCH] staging: brcm80211: Coalesce osl_dma_alloc_consistent between fullmac and softmac Combine dma_alloc routine for full and softmac Signed-off-by: Brett Rudley Signed-off-by: Greg Kroah-Hartman --- drivers/staging/brcm80211/include/linux_osl.h | 17 ++++++++--------- drivers/staging/brcm80211/util/linux_osl.c | 20 ++++++-------------- 2 files changed, 14 insertions(+), 23 deletions(-) diff --git a/drivers/staging/brcm80211/include/linux_osl.h b/drivers/staging/brcm80211/include/linux_osl.h index ea1de98b59a..a8ccc74cc4b 100644 --- a/drivers/staging/brcm80211/include/linux_osl.h +++ b/drivers/staging/brcm80211/include/linux_osl.h @@ -107,20 +107,19 @@ extern uint osl_malloced(osl_t *osh); #define NATIVE_MALLOC(osh, size) kmalloc(size, GFP_ATOMIC) #define NATIVE_MFREE(osh, addr, size) kfree(addr) +#define DMA_CONSISTENT_ALIGN osl_dma_consistent_align() +extern uint osl_dma_consistent_align(void); +extern void *osl_dma_alloc_consistent(osl_t *osh, uint size, u16 align, + uint *tot, unsigned long *pap); + #ifdef BRCM_FULLMAC -#define DMA_CONSISTENT_ALIGN PAGE_SIZE #define DMA_ALLOC_CONSISTENT(osh, size, pap, dmah, alignbits) \ - osl_dma_alloc_consistent((osh), (size), (pap)) -extern void *osl_dma_alloc_consistent(osl_t *osh, uint size, unsigned long *pap); + osl_dma_alloc_consistent((osh), (size), (0), (tot), (pap)) #else -/* allocate/free shared (dma-able) consistent memory */ -#define DMA_CONSISTENT_ALIGN osl_dma_consistent_align() #define DMA_ALLOC_CONSISTENT(osh, size, align, tot, pap, dmah) \ osl_dma_alloc_consistent((osh), (size), (align), (tot), (pap)) -extern uint osl_dma_consistent_align(void); -extern void *osl_dma_alloc_consistent(osl_t *osh, uint size, u16 align, - uint *tot, unsigned long *pap); -#endif +#endif /* BRCM_FULLMAC */ + #define DMA_FREE_CONSISTENT(osh, va, size, pa, dmah) \ osl_dma_free_consistent((osh), (void *)(va), (size), (pa)) extern void osl_dma_free_consistent(osl_t *osh, void *va, uint size, unsigned long pa); diff --git a/drivers/staging/brcm80211/util/linux_osl.c b/drivers/staging/brcm80211/util/linux_osl.c index 096f8095219..391f33caafd 100644 --- a/drivers/staging/brcm80211/util/linux_osl.c +++ b/drivers/staging/brcm80211/util/linux_osl.c @@ -505,27 +505,19 @@ uint osl_dma_consistent_align(void) return PAGE_SIZE; } -#ifdef BRCM_FULLMAC -void *osl_dma_alloc_consistent(osl_t *osh, uint size, unsigned long *pap) -{ - ASSERT((osh && (osh->magic == OS_HANDLE_MAGIC))); - - return pci_alloc_consistent(osh->pdev, size, (dma_addr_t *) pap); -} -#else /* !BRCM_FULLMAC */ void *osl_dma_alloc_consistent(osl_t *osh, uint size, u16 align_bits, uint *alloced, unsigned long *pap) { - u16 align = (1 << align_bits); ASSERT((osh && (osh->magic == OS_HANDLE_MAGIC))); - if (!IS_ALIGNED(DMA_CONSISTENT_ALIGN, align)) - size += align; - *alloced = size; - + if (align_bits) { + u16 align = (1 << align_bits); + if (!IS_ALIGNED(DMA_CONSISTENT_ALIGN, align)) + size += align; + *alloced = size; + } return pci_alloc_consistent(osh->pdev, size, (dma_addr_t *) pap); } -#endif /* BRCM_FULLMAC */ void osl_dma_free_consistent(osl_t *osh, void *va, uint size, unsigned long pa) { -- 2.11.4.GIT