| commit | cdb32706f6948238ed6d1d85473c64c27366e9e9 | |
| author | Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz> | |
| Thu, 22 Nov 2007 20:26:01 +0000 (22 21:26 +0100) | ||
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | |
| Tue, 27 Nov 2007 03:39:01 +0000 (26 19:39 -0800) | ||
| tree | bc8b267a0b861bbafae9c384cf80a03e14db8bbd | treesnapshot (tar.gz zip) |
| parent | f6ce5cca74b8681fdf1d7307edc66a7213b43f6f | commitdiff |
plip: fix parport_register_device name parameter
Plip passes a string "name" that is allocated on stack to
parport_register_device. parport_register_device holds the pointer to
"name" and when the registering function exits, it points nowhere.
On some machine, this bug causes bad names to appear in /proc, such as
/proc/sys/dev/parport/parport0/devices/T^/�X^/�, on others, the plip
proc node is completely missing.
The patch also fixes documentation to note this requirement.
Signed-off-by: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Plip passes a string "name" that is allocated on stack to
parport_register_device. parport_register_device holds the pointer to
"name" and when the registering function exits, it points nowhere.
On some machine, this bug causes bad names to appear in /proc, such as
/proc/sys/dev/parport/parport0/devices/T^/�X^/�, on others, the plip
proc node is completely missing.
The patch also fixes documentation to note this requirement.
Signed-off-by: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| Documentation/parport-lowlevel.txt | diffblobblamehistory | |
| drivers/net/plip.c | diffblobblamehistory |