| commit | bb31b3122c0dd07d2d958da17a50ad771ce79e2b | |
| author | Borislav Petkov <borislav.petkov@amd.com> | |
| Thu, 2 Dec 2010 16:48:35 +0000 (2 17:48 +0100) | ||
| committer | Borislav Petkov <borislav.petkov@amd.com> | |
| Wed, 8 Dec 2010 18:52:27 +0000 (8 19:52 +0100) | ||
| tree | c76193ec64772ee387be80245e86d093ab16c908 | treesnapshot (tar.gz zip) |
| parent | cf7d7e5a1980d1116ee152d25dac382b112b9c17 | commitdiff |
EDAC: Fix workqueue-related crashes
00740c58541b6087d78418cebca1fcb86dc6077d changed edac_core to
un-/register a workqueue item only if a lowlevel driver supplies a
polling routine. Normally, when we remove a polling low-level driver, we
go and cancel all the queued work. However, the workqueue unreg happens
based on the ->op_state setting, and edac_mc_del_mc() sets this to
OP_OFFLINE _before_ we cancel the work item, leading to NULL ptr oops on
the workqueue list.
Fix it by putting the unreg stuff in proper order.
Cc: <stable@kernel.org> #36.x
Reported-and-tested-by: Tobias Karnat <tobias.karnat@googlemail.com>
LKML-Reference: <1291201307.3029.21.camel@Tobias-Karnat>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
00740c58541b6087d78418cebca1fcb86dc6077d changed edac_core to
un-/register a workqueue item only if a lowlevel driver supplies a
polling routine. Normally, when we remove a polling low-level driver, we
go and cancel all the queued work. However, the workqueue unreg happens
based on the ->op_state setting, and edac_mc_del_mc() sets this to
OP_OFFLINE _before_ we cancel the work item, leading to NULL ptr oops on
the workqueue list.
Fix it by putting the unreg stuff in proper order.
Cc: <stable@kernel.org> #36.x
Reported-and-tested-by: Tobias Karnat <tobias.karnat@googlemail.com>
LKML-Reference: <1291201307.3029.21.camel@Tobias-Karnat>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
| drivers/edac/edac_mc.c | diffblobblamehistory |