net: percpu_counter_inc() should not be called in BH-disabled section
commit6976a1d6c222c50ac93d2273b9cf57e6fd047e59
authorEric Dumazet <dada1@cosmosbay.com>
Tue, 2 Dec 2008 07:37:17 +0000 (1 23:37 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 2 Dec 2008 07:37:17 +0000 (1 23:37 -0800)
treeba2973e7c724b16d5e176438ae635dac4d74bc75
parent422d9cdcb85b3622d08a590fed66021af7aea333
net: percpu_counter_inc() should not be called in BH-disabled section

Based upon a lockdep report by Alexey Dobriyan.

I checked all per_cpu_counter_xxx() usages in network tree, and I
think all call sites are BH enabled except one in
inet_csk_listen_stop().

commit dd24c00191d5e4a1ae896aafe33c6b8095ab4bd1
(net: Use a percpu_counter for orphan_count)
replaced atomic_t orphan_count to a percpu_counter.

atomic_inc()/atomic_dec() can be called from any context, while
percpu_counter_xxx() should be called from a consistent state.

For orphan_count, this context can be the BH-enabled one.

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/inet_connection_sock.c