| commit | 1492616a434dae1908d0da2d6ee6605ca5a77e6f | |
| author | Axel Lin <axel.lin@gmail.com> | |
| Mon, 28 Jun 2010 01:30:45 +0000 (28 09:30 +0800) | ||
| committer | Matthew Garrett <mjg@redhat.com> | |
| Tue, 3 Aug 2010 13:48:51 +0000 (3 09:48 -0400) | ||
| tree | 4bab4bca46acbf15e242e6663b313e05f1d1be06 | treesnapshot (tar.gz zip) |
| parent | d5164dbf1f651d1e955b158fb70a9c844cc91cd1 | commitdiff |
wmi: fix a memory leak in wmi_notify_debug
When acpi_evaluate_object() is passed ACPI_ALLOCATE_BUFFER,
the caller must kfree the returned buffer if AE_OK is returned.
The callers of wmi_get_event_data() pass ACPI_ALLOCATE_BUFFER,
and thus must check its return value before accessing
or kfree() on the buffer.
This patch adds return value checking for wmi_get_event_data()
and adds a missing kfree(obj) in the end of wmi_notify_debug
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
When acpi_evaluate_object() is passed ACPI_ALLOCATE_BUFFER,
the caller must kfree the returned buffer if AE_OK is returned.
The callers of wmi_get_event_data() pass ACPI_ALLOCATE_BUFFER,
and thus must check its return value before accessing
or kfree() on the buffer.
This patch adds return value checking for wmi_get_event_data()
and adds a missing kfree(obj) in the end of wmi_notify_debug
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
| drivers/platform/x86/wmi.c | diffblobblamehistory |