| commit | 11a6b292c1bc9cb39970e44edd6958250f23d3a8 | |
| author | Michael Ellerman <michael@ellerman.id.au> | |
| Sun, 5 Jul 2009 16:08:52 +0000 (5 16:08 +0000) | ||
| committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | |
| Thu, 20 Aug 2009 00:12:22 +0000 (20 10:12 +1000) | ||
| tree | ac23c82f0739ad7521b531f570305d2a306c7651 | treesnapshot (tar.gz zip) |
| parent | 66dc3304f3875ea85c630a57a88ecf79032890c4 | commitdiff |
powerpc/mpic: Fix MPIC_BROKEN_REGREAD on non broken MPICs
The workaround enabled by CONFIG_MPIC_BROKEN_REGREAD does not work
on non-broken MPICs. The symptom is no interrupts being received.
The fix is twofold. Firstly the code was broken for multiple isus,
we need to index into the shadow array with the src_no, not the idx.
Secondly, we always do the read, but only use the VECPRI_MASK and
VECPRI_ACTIVITY bits from the hardware, the rest of "val" comes
from the shadow.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
The workaround enabled by CONFIG_MPIC_BROKEN_REGREAD does not work
on non-broken MPICs. The symptom is no interrupts being received.
The fix is twofold. Firstly the code was broken for multiple isus,
we need to index into the shadow array with the src_no, not the idx.
Secondly, we always do the read, but only use the VECPRI_MASK and
VECPRI_ACTIVITY bits from the hardware, the rest of "val" comes
from the shadow.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
| arch/powerpc/sysdev/mpic.c | diffblobblamehistory |