| commit | 0efc22f3afa5d8f070a33fea06162d7d9d518e38 | |
| author | Stanislaw Gruszka <sgruszka@redhat.com> | |
| Tue, 9 Mar 2010 06:55:01 +0000 (9 06:55 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Mon, 15 Mar 2010 22:47:00 +0000 (15 15:47 -0700) | ||
| tree | a4697a795999df7bfe11e89038e53664927195f9 | treesnapshot (tar.gz zip) |
| parent | 2d99cf16f42b1979a2c498bb6d09498dbd689978 | commitdiff |
bnx2x: remove not necessary compiler barrier
Access to fp->tx_bd_prod is protected by __netif_tx_lock, so we do not
need any barrier for that.
Update of fp->tx_bd_cons in bnx2x_tx_int() is not protected by lock, but
barrier() nor smb_mb() in bnx2x_tx_avail() not guarantee we will see
values that is written on other cpu. Ordering issues between
netif_tx_stop_queue(), netif_tx_queue_stopped(), fp->tx_bd_cons = bd_cons
and bnx2x_tx_avail() are already handled by smp_mb() in bnx2x_tx_int()
and bnx2x_start_xmit().
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Access to fp->tx_bd_prod is protected by __netif_tx_lock, so we do not
need any barrier for that.
Update of fp->tx_bd_cons in bnx2x_tx_int() is not protected by lock, but
barrier() nor smb_mb() in bnx2x_tx_avail() not guarantee we will see
values that is written on other cpu. Ordering issues between
netif_tx_stop_queue(), netif_tx_queue_stopped(), fp->tx_bd_cons = bd_cons
and bnx2x_tx_avail() are already handled by smp_mb() in bnx2x_tx_int()
and bnx2x_start_xmit().
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/bnx2x_main.c | diffblobblamehistory |