| commit | dedc9937e876cb5430bca6a1dccfcc2ff22f8b7c | |
| author | Jon Mason <jdmason@kudzu.us> | |
| Thu, 5 Oct 2006 16:47:21 +0000 (5 18:47 +0200) | ||
| committer | Andi Kleen <andi@basil.nowhere.org> | |
| Thu, 5 Oct 2006 16:47:21 +0000 (5 18:47 +0200) | ||
| tree | befdff79af02b30ba42cfdb983343ea7ec7b363f | treesnapshot (tar.gz zip) |
| parent | 814eadcefe79a2977a11ba135c4763a402112746 | commitdiff |
[PATCH] x86-64: Calgary IOMMU: deobfuscate calgary_init
calgary_init's for loop does not correspond to the actual device being
checked, which makes its upperbound check for array overflow useless.
Changing this to a do-while loop is the correct way of doing this.
There should be no possibility of spinning forever in this loop, as
pci_get_device states that it will go through all iterations, then
return NULL (thus breaking the loop).
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Muli Ben-Yehuda <muli@il.ibm.com>
Signed-off-by: Andi Kleen <ak@suse.de>
calgary_init's for loop does not correspond to the actual device being
checked, which makes its upperbound check for array overflow useless.
Changing this to a do-while loop is the correct way of doing this.
There should be no possibility of spinning forever in this loop, as
pci_get_device states that it will go through all iterations, then
return NULL (thus breaking the loop).
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Muli Ben-Yehuda <muli@il.ibm.com>
Signed-off-by: Andi Kleen <ak@suse.de>
| arch/x86_64/kernel/pci-calgary.c | diffblobblamehistory |