| commit | 71795c1df30b034414c921b4930ed88de34ca348 | |
| author | Pete Zaitcev <zaitcev@redhat.com> | |
| Tue, 19 Sep 2006 05:57:22 +0000 (18 22:57 -0700) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Wed, 27 Sep 2006 18:59:00 +0000 (27 11:59 -0700) | ||
| tree | 962dc749e8d56bb90d9b40c2401d6519eca8f630 | treesnapshot (tar.gz zip) |
| parent | 38e2bfc94e95dd6005fdaf40dfec0157396741da | commitdiff |
USB: ohci_usb can oops on shutdown
When ohci-hcd is shutting down (for rmmod or PC-card removal), there is
a window when the device is shut down, HC communication area (->hcca)
is freed, but the core has not called "free_irq" yet. If another device
triggers a shared interrupt in this window, we oops when trying to
access the freed ->hcca.
This patch removes the window by calling free_irq before ->hcca is freed.
The patch is tested at the PC hotplug test rig at Stratus, and with
rmmod by Rafael Wysocki.
Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
When ohci-hcd is shutting down (for rmmod or PC-card removal), there is
a window when the device is shut down, HC communication area (->hcca)
is freed, but the core has not called "free_irq" yet. If another device
triggers a shared interrupt in this window, we oops when trying to
access the freed ->hcca.
This patch removes the window by calling free_irq before ->hcca is freed.
The patch is tested at the PC hotplug test rig at Stratus, and with
rmmod by Rafael Wysocki.
Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/usb/host/ohci-hcd.c | diffblobblamehistory |