| commit | eef3a116be11d35396efb2a8cc7345fd3221e294 | |
| author | Eric Paris <eparis@redhat.com> | |
| Mon, 17 Aug 2009 01:51:44 +0000 (16 21:51 -0400) | ||
| committer | Linus Torvalds <torvalds@linux-foundation.org> | |
| Mon, 17 Aug 2009 20:37:37 +0000 (17 13:37 -0700) | ||
| tree | 2a5d0b36dd5985f29eac43f51b03e610e40b7c9b | treesnapshot (tar.gz zip) |
| parent | 0f66f96d21b4bbff49baaa337546e687d7c58e87 | commitdiff |
notify: unused event private race
inotify decides if private data it passed to get added to an event was
used by checking list_empty(). But it's possible that the event may
have been dequeued and the private event removed so it would look empty.
The fix is to use the return code from fsnotify_add_notify_event rather
than looking at the list.
Signed-off-by: Eric Paris <eparis@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
inotify decides if private data it passed to get added to an event was
used by checking list_empty(). But it's possible that the event may
have been dequeued and the private event removed so it would look empty.
The fix is to use the return code from fsnotify_add_notify_event rather
than looking at the list.
Signed-off-by: Eric Paris <eparis@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| fs/notify/inotify/inotify_fsnotify.c | diffblobblamehistory | |
| fs/notify/inotify/inotify_user.c | diffblobblamehistory | |
| fs/notify/notification.c | diffblobblamehistory |