| commit | 947b10ae0aeda89fc066a7470fdba55f72b0b8fc | |
| author | Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> | |
| Thu, 16 Dec 2010 00:57:57 +0000 (16 09:57 +0900) | ||
| committer | Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> | |
| Thu, 16 Dec 2010 05:35:18 +0000 (16 14:35 +0900) | ||
| tree | 93934dcf6b7709ed40e861d3b586f2c3f37f4151 | treesnapshot (tar.gz zip) |
| parent | b0c3844d8af6b9f3f18f31e1b0502fbefa2166be | commitdiff |
nilfs2: fix regression of garbage collection ioctl
On 2.6.37-rc1, garbage collection ioctl of nilfs was broken due to the
commit 263d90cefc7d82a0 ("nilfs2: remove own inode hash used for GC"),
and leading to filesystem corruption.
The patch doesn't queue gc-inodes for log writer if they are reused
through the vfs inode cache. Here, gc-inode is the inode which
buffers blocks to be relocated on GC. That patch queues gc-inodes in
nilfs_init_gcinode() function, but this function is not called when
they don't have I_NEW flag. Thus, some of live blocks are wrongly
overrode without being moved to new logs.
This resolves the problem by moving the gc-inode queueing to an outer
function to ensure it's done right.
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
On 2.6.37-rc1, garbage collection ioctl of nilfs was broken due to the
commit 263d90cefc7d82a0 ("nilfs2: remove own inode hash used for GC"),
and leading to filesystem corruption.
The patch doesn't queue gc-inodes for log writer if they are reused
through the vfs inode cache. Here, gc-inode is the inode which
buffers blocks to be relocated on GC. That patch queues gc-inodes in
nilfs_init_gcinode() function, but this function is not called when
they don't have I_NEW flag. Thus, some of live blocks are wrongly
overrode without being moved to new logs.
This resolves the problem by moving the gc-inode queueing to an outer
function to ensure it's done right.
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
| fs/nilfs2/gcinode.c | diffblobblamehistory | |
| fs/nilfs2/ioctl.c | diffblobblamehistory |