| commit | 7e5998aa74065d3ab31d17e667f40ffebf4b8425 | |
| author | Dan Carpenter <dan.carpenter@oracle.com> | |
| Tue, 17 Apr 2012 20:53:42 +0000 (17 20:53 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Thu, 19 Apr 2012 19:22:44 +0000 (19 15:22 -0400) | ||
| tree | fd29b26607e2e7be259c8ddf3e11e932bfdfa13e | treesnapshot (tar.gz zip) |
| parent | 716af4abd6e6370226f567af50bfaca274515980 | commitdiff |
bnx2x: off by one in bnx2x_ets_e3b0_sp_pri_to_cos_set()
The sp_pri_to_cos[] array size depends on the config but lets say it is
BX_E3B0_MAX_NUM_COS_PORT0 and max_num_of_cos is also
DCBX_E3B0_MAX_NUM_COS_PORT0. In the original code
"pri == max_num_of_cos" was accepted but it is one past the end of the
array.
Also we used "pri" before capping it. It's a harmless read past the end
of the array, but it would affect which error message gets printed.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
The sp_pri_to_cos[] array size depends on the config but lets say it is
BX_E3B0_MAX_NUM_COS_PORT0 and max_num_of_cos is also
DCBX_E3B0_MAX_NUM_COS_PORT0. In the original code
"pri == max_num_of_cos" was accepted but it is one past the end of the
array.
Also we used "pri" before capping it. It's a harmless read past the end
of the array, but it would affect which error message gets printed.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | diffblobblamehistory |