| commit | 7cfe21aae155c26193fde617dc61d37a79a63f86 | |
| author | Stefan Richter <stefanr@s5r6.in-berlin.de> | |
| Sat, 10 Apr 2010 15:47:18 +0000 (10 16:47 +0100) | ||
| committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | |
| Sat, 10 Apr 2010 14:51:15 +0000 (10 16:51 +0200) | ||
| tree | 6600d3171afdfad430155f5e8a1f526367a6174d | treesnapshot (tar.gz zip) |
| parent | 3ac26b2ee30005930117fe6a180c139c5f300faf | commitdiff |
ieee1394: mark char device files as not seekable
The
- raw1394 (/dev/raw1394),
- video1394 (/dev/video1394/*),
- dv1394 (/dev/dv1394/*)
character device file ABIs do not make any use of lseek(), pread(), or
pwrite(). Therefore use nonseekable_open() and, redundantly, set
file_operations.llseek to no_llseek to remove any doubt whether the BKL-
grabbing default_llseek handler is used.
Although all this is legacy code which should be left in peace until it
is eventually removed (as it is superseded by firewire-core's
<linux/firewire-cdev.h> ABI), this change seems still worth doing to
further minimize the presence of BKL usage in the kernel.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
The
- raw1394 (/dev/raw1394),
- video1394 (/dev/video1394/*),
- dv1394 (/dev/dv1394/*)
character device file ABIs do not make any use of lseek(), pread(), or
pwrite(). Therefore use nonseekable_open() and, redundantly, set
file_operations.llseek to no_llseek to remove any doubt whether the BKL-
grabbing default_llseek handler is used.
Although all this is legacy code which should be left in peace until it
is eventually removed (as it is superseded by firewire-core's
<linux/firewire-cdev.h> ABI), this change seems still worth doing to
further minimize the presence of BKL usage in the kernel.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
| drivers/ieee1394/dv1394.c | diffblobblamehistory | |
| drivers/ieee1394/raw1394.c | diffblobblamehistory | |
| drivers/ieee1394/video1394.c | diffblobblamehistory |