| commit | 6af9a43d58f2ec455b752fb9534cf05c7e855dbe | |
| author | Jiri Slaby <jirislaby@gmail.com> | |
| Wed, 24 Jun 2009 17:35:05 +0000 (24 18:35 +0100) | ||
| committer | Linus Torvalds <torvalds@linux-foundation.org> | |
| Wed, 24 Jun 2009 16:55:50 +0000 (24 09:55 -0700) | ||
| tree | 43fbe1b0823392eda912b76bc3f180e651f47d6c | treesnapshot (tar.gz zip) |
| parent | 24ed3abaa13a9499d7454a1ed9830bb53b689b94 | commitdiff |
tty: fix tty_port_block_til_ready waiting
Since commit 3e3b5c087799e536871c8261b05bc28e4783c8da ("tty: use
prepare/finish_wait"), tty_port_block_til_ready() is using
prepare_to_wait()/finish_wait(). Those functions require that the
wait_queue_t be initialised with .func=autoremove_wake_function, via
DEFINE_WAIT().
But the conversion from DECLARE_WAITQUEUE() to DEFINE_WAIT() was not made,
so this code will oops in finish_wait().
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Since commit 3e3b5c087799e536871c8261b05bc28e4783c8da ("tty: use
prepare/finish_wait"), tty_port_block_til_ready() is using
prepare_to_wait()/finish_wait(). Those functions require that the
wait_queue_t be initialised with .func=autoremove_wake_function, via
DEFINE_WAIT().
But the conversion from DECLARE_WAITQUEUE() to DEFINE_WAIT() was not made,
so this code will oops in finish_wait().
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| drivers/char/tty_port.c | diffblobblamehistory |