| commit | 380517dead6ab86d7249a1723f07f2f1b10af5f6 | |
| author | Patrick McHardy <kaber@trash.net> | |
| Thu, 31 Jan 2008 12:40:04 +0000 (31 04:40 -0800) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Fri, 1 Feb 2008 03:27:56 +0000 (31 19:27 -0800) | ||
| tree | 3b6cee7a9b246305c5a98d62aba00aebdde6d77b | treesnapshot (tar.gz zip) |
| parent | ba419aff2cda91680e5d4d3eeff95df49bd2edec | commitdiff |
[NETFILTER]: nf_conntrack: avoid duplicate protocol comparison in nf_ct_tuple_equal()
nf_ct_tuple_src_equal() and nf_ct_tuple_dst_equal() both compare the protocol
numbers. Unfortunately gcc doesn't optimize out the second comparison, so
remove it and prefix both functions with __ to indicate that they should not
be used directly.
Saves another 16 byte of text in __nf_conntrack_find() on x86_64:
nf_conntrack_tuple_taken | -20 # 320 -> 300, size inlines: 181 -> 161
__nf_conntrack_find | -16 # 267 -> 251, size inlines: 127 -> 115
__nf_conntrack_confirm | -40 # 875 -> 835, size inlines: 570 -> 537
3 functions changed, 76 bytes removed
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
nf_ct_tuple_src_equal() and nf_ct_tuple_dst_equal() both compare the protocol
numbers. Unfortunately gcc doesn't optimize out the second comparison, so
remove it and prefix both functions with __ to indicate that they should not
be used directly.
Saves another 16 byte of text in __nf_conntrack_find() on x86_64:
nf_conntrack_tuple_taken | -20 # 320 -> 300, size inlines: 181 -> 161
__nf_conntrack_find | -16 # 267 -> 251, size inlines: 127 -> 115
__nf_conntrack_confirm | -40 # 875 -> 835, size inlines: 570 -> 537
3 functions changed, 76 bytes removed
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
| include/net/netfilter/nf_conntrack_tuple.h | diffblobblamehistory |