| commit | fe47d563065c91cd30088d9b118b79d44905be6f | |
| author | Vivien Didelot <vivien.didelot@savoirfairelinux.com> | |
| Thu, 1 Jun 2017 20:07:15 +0000 (1 16:07 -0400) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Thu, 1 Jun 2017 21:34:56 +0000 (1 17:34 -0400) | ||
| tree | a45ba1a54b080a3a71e4650f03d57ac3de3767e8 | treesnapshot (tar.gz zip) |
| parent | 5470979585d81271d4338c2accfd5e71dafa4af6 | commitdiff |
net: dsa: factor skb freeing on xmit
As of a86d8becc3f0 ("net: dsa: Factor bottom tag receive functions"),
the rcv caller frees the original SKB in case or error.
Be symmetric with that and make the xmit caller do the same.
At the same time, fix the checkpatch NULL comparison check:
CHECK: Comparison to NULL could be written "!nskb"
#208: FILE: net/dsa/tag_trailer.c:35:
+ if (nskb == NULL)
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
As of a86d8becc3f0 ("net: dsa: Factor bottom tag receive functions"),
the rcv caller frees the original SKB in case or error.
Be symmetric with that and make the xmit caller do the same.
At the same time, fix the checkpatch NULL comparison check:
CHECK: Comparison to NULL could be written "!nskb"
#208: FILE: net/dsa/tag_trailer.c:35:
+ if (nskb == NULL)
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>