| commit | f8112a1de1a728ffef0dd9f6c3005490c5f79ab1 | |
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | |
| Mon, 2 Jul 2018 20:05:26 +0000 (2 22:05 +0200) | ||
| committer | Jacek Anaszewski <jacek.anaszewski@gmail.com> | |
| Thu, 5 Jul 2018 21:21:12 +0000 (5 23:21 +0200) | ||
| tree | 2013461f5b4180fc422705ec8220761a967de30e | treesnapshot (tar.gz zip) |
| parent | 9acc560de2aac73ef99c54f0fdfb86b4684296b5 | commitdiff |
leds: netdev trigger: simplifications from core changes
The trigger core learned error handling for the activate callback and
can handle device attributes now. This allows simplifying the driver
considerably. Note that .deactivate() is only called when .activate()
succeeded, so the check for trigger_data being non-NULL can go away.
(It was broken before because the core didn't clear .trigger_data, so it
might have been non-NULL even if .activate() failed before.)
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
The trigger core learned error handling for the activate callback and
can handle device attributes now. This allows simplifying the driver
considerably. Note that .deactivate() is only called when .activate()
succeeded, so the check for trigger_data being non-NULL can go away.
(It was broken before because the core didn't clear .trigger_data, so it
might have been non-NULL even if .activate() failed before.)
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
| drivers/leds/trigger/ledtrig-netdev.c | diffblobblamehistory |