| commit | f5cd2ae1e4ad23bc6527b4a667d3f27534730cc5 | |
| author | Brian Norris <computersforpeace@gmail.com> | |
| Sat, 28 Feb 2015 10:13:13 +0000 (28 02:13 -0800) | ||
| committer | Brian Norris <computersforpeace@gmail.com> | |
| Thu, 7 May 2015 03:02:37 +0000 (6 20:02 -0700) | ||
| tree | db6afc8de0be0581cffc2d7a0999f13614514f4a | treesnapshot (tar.gz zip) |
| parent | 83c59542d0af36d6331e11869cd3d8197dec1551 | commitdiff |
mtd: nand_bbt: fix theoretical integer overflow in BBT write
This statement was written with a cast-to-loff_t to be sure to have a
full 64-bit mask. However, we don't account for the fact that
'1 << this->bbt_erase_shift' might already overflow.
This will not be a problem in practice, since eraseblocks should never
be anywhere near 4GiB. But we can do this for completeness, and quiet
Coverity in the meantime. CID #1226806.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
This statement was written with a cast-to-loff_t to be sure to have a
full 64-bit mask. However, we don't account for the fact that
'1 << this->bbt_erase_shift' might already overflow.
This will not be a problem in practice, since eraseblocks should never
be anywhere near 4GiB. But we can do this for completeness, and quiet
Coverity in the meantime. CID #1226806.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
| drivers/mtd/nand/nand_bbt.c | diffblobblamehistory |