| commit | e7e70fa6784b48a811fdd4253c41fc7195300570 | |
| author | Colin Ian King <colin.king@canonical.com> | |
| Tue, 16 Jan 2018 10:22:50 +0000 (16 10:22 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Tue, 16 Jan 2018 20:24:29 +0000 (16 15:24 -0500) | ||
| tree | 87a84bd75934ca05dec86fd49097902fcfaa5ff7 | treesnapshot (tar.gz zip) |
| parent | 96890d62523c2cddc2c053ad29de35c4d935cf11 | commitdiff |
bnxt_en: don't update cpr->rx_bytes with uninitialized length len
Currently in the cases where cmp_type == CMP_TYPE_RX_L2_TPA_START_CMP or
CMP_TYPE_RX_L2_TPA_END_CMP the exit path updates cpr->rx_bytes with an
uninitialized length len. Fix this by adding a new exit path that does
not update the cpr stats with the bogus length len and remove the unused
label next_rx_no_prod.
Detected by CoverityScan, CID#1463807 ("Uninitialized scalar variable")
Fixes: 6a8788f25625 ("bnxt_en: add support for software dynamic interrupt moderation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Currently in the cases where cmp_type == CMP_TYPE_RX_L2_TPA_START_CMP or
CMP_TYPE_RX_L2_TPA_END_CMP the exit path updates cpr->rx_bytes with an
uninitialized length len. Fix this by adding a new exit path that does
not update the cpr stats with the bogus length len and remove the unused
label next_rx_no_prod.
Detected by CoverityScan, CID#1463807 ("Uninitialized scalar variable")
Fixes: 6a8788f25625 ("bnxt_en: add support for software dynamic interrupt moderation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/ethernet/broadcom/bnxt/bnxt.c | diffblobblamehistory |