char: ipmi: constify ipmi_smi_handlers structures
commitdb3b7e134185b27e6073618c1ad7eca1e4473eb4
authorBhumika Goyal <bhumirks@gmail.com>
Sun, 15 Jan 2017 19:15:00 +0000 (16 00:45 +0530)
committerCorey Minyard <cminyard@mvista.com>
Thu, 9 Feb 2017 15:10:56 +0000 (9 09:10 -0600)
treef123d9a21f1a1f17f0cef66001cabfbee9e1a06b
parentc690d141489b0788db9ba95cc33075ad37d3ec30
char: ipmi: constify ipmi_smi_handlers structures

Declare ipmi_smi_handlers structures as const as they are only passed as
an argument to the function ipmi_register_smi. This argument is of type
const, so ipmi_smi_handlers structures having similar properties can be
declared const too.
Done using Coccinelle:

@r1 disable optional_qualifier@
identifier i;
position p;
@@
static struct ipmi_smi_handlers i@p={...};

@ok1@
identifier r1.i;
position p;
@@
ipmi_register_smi(&i@p,...)

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct ipmi_smi_handlers i;

Size details after cross compiling the .o file for powerpc architecture

File size before:
  text    data     bss     dec     hex filename
  2777     288       0    3065     bf9 drivers/char/ipmi/ipmi_powernv.o

File size after:
  text    data     bss     dec     hex filename
   2873     192       0    3065     bf9 drivers/char/ipmi/ipmi_powernv.o

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
drivers/char/ipmi/ipmi_powernv.c