| commit | d0ef440350ff9d1c72e52c837302df090c4d2725 | |
| author | Tyrel Datwyler <tyreld@linux.vnet.ibm.com> | |
| Thu, 15 Aug 2013 05:23:47 +0000 (14 22:23 -0700) | ||
| committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | |
| Tue, 27 Aug 2013 04:45:12 +0000 (27 14:45 +1000) | ||
| tree | 5f6fe3807334f31db85c066d9a4ad2f47cb88b05 | treesnapshot (tar.gz zip) |
| parent | 638a405fb52cfb2e7f559e869dd0291420b9e84d | commitdiff |
powerpc/pseries: Pack update_props_workarea to map correctly to rtas buffer header
The work area buffer returned by the ibm,update-properties rtas call contains
20 bytes of header information prior to the property value descriptor data.
Currently update_dt_node tries to advance over this header using sizeof(upwa).
The update_props_workarea struct contains 20 bytes worth of fields, that map
to the relevant header data, but the sizeof the structure is 24 bytes due to
4 bytes of padding at the end of the structure. Packing the structure ensures
that we don't advance too far over the rtas buffer.
Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Acked-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
The work area buffer returned by the ibm,update-properties rtas call contains
20 bytes of header information prior to the property value descriptor data.
Currently update_dt_node tries to advance over this header using sizeof(upwa).
The update_props_workarea struct contains 20 bytes worth of fields, that map
to the relevant header data, but the sizeof the structure is 24 bytes due to
4 bytes of padding at the end of the structure. Packing the structure ensures
that we don't advance too far over the rtas buffer.
Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Acked-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
| arch/powerpc/platforms/pseries/mobility.c | diffblobblamehistory |