| commit | bdbc5d0c60f3e9de3eeccf1c1a18bdc11dca62cc | |
| author | Terry Barnaby <terry@beam.ltd.uk> | |
| Mon, 8 Apr 2013 16:05:47 +0000 (8 12:05 -0400) | ||
| committer | Chris Ball <cjb@laptop.org> | |
| Mon, 8 Apr 2013 16:05:47 +0000 (8 12:05 -0400) | ||
| tree | 1c20e5a4c777bf3295bd98710ed7277030b42154 | treesnapshot (tar.gz zip) |
| parent | 836dc2fe89c968c10cada87e0dfae6626f8f9da3 | commitdiff |
mmc: atmel-mci: pio hang on block errors
The driver is doing, by default, multi-block reads. When a block error
occurs, card/block.c instigates a single block read: "mmcblk0: retrying
using single block read". It leaves the sg chain intact and just changes
the length attribute for the first sg entry and the overall sg_len
parameter. When atmci_read_data_pio is called to read the single block
of data it ignores the sg_len and expects to read more than 512 bytes as
it sees there are multiple items in the sg list. No more data comes as
the controller has only been commanded to get one block.
Signed-off-by: Terry Barnaby <terry@beam.ltd.uk>
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Cc: stable <stable@vger.kernel.org> # 3.2+
Signed-off-by: Chris Ball <cjb@laptop.org>
The driver is doing, by default, multi-block reads. When a block error
occurs, card/block.c instigates a single block read: "mmcblk0: retrying
using single block read". It leaves the sg chain intact and just changes
the length attribute for the first sg entry and the overall sg_len
parameter. When atmci_read_data_pio is called to read the single block
of data it ignores the sg_len and expects to read more than 512 bytes as
it sees there are multiple items in the sg list. No more data comes as
the controller has only been commanded to get one block.
Signed-off-by: Terry Barnaby <terry@beam.ltd.uk>
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Cc: stable <stable@vger.kernel.org> # 3.2+
Signed-off-by: Chris Ball <cjb@laptop.org>
| drivers/mmc/host/atmel-mci.c | diffblobblamehistory |