| commit | ab7f6fcec33a01279d2abeaf1c4ccdfa8a5d93ff | |
| author | Brian Norris <computersforpeace@gmail.com> | |
| Wed, 21 May 2014 05:47:26 +0000 (20 22:47 -0700) | ||
| committer | Brian Norris <computersforpeace@gmail.com> | |
| Wed, 28 May 2014 07:05:26 +0000 (28 00:05 -0700) | ||
| tree | 7cfeb29c8fe79ebc80e743b79b901037baf5c2bc | treesnapshot (tar.gz zip) |
| parent | abb9cf78e80ab4407c3efb0950f08e6941bc7e73 | commitdiff |
mtd: nand: r852: correct write_buf loop bounds
The two loops in r852_write_buf() are designed to handle 4-byte-aligned
and then 1-byte-aligned portions, respectively. However, there are two
issues:
(1) The first loop will only terminate if 'len' is a multiple of 4
(2) The second loop will never terminate if it runs at least once
Rewrite these loops as they were probably intended. Compile tested only.
Issues pointed out by Coverity Scan.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>
The two loops in r852_write_buf() are designed to handle 4-byte-aligned
and then 1-byte-aligned portions, respectively. However, there are two
issues:
(1) The first loop will only terminate if 'len' is a multiple of 4
(2) The second loop will never terminate if it runs at least once
Rewrite these loops as they were probably intended. Compile tested only.
Issues pointed out by Coverity Scan.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>
| drivers/mtd/nand/r852.c | diffblobblamehistory |