| commit | aad06212d36cf34859428a0a279e5c14ee5c9e26 | |
| author | Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com> | |
| Fri, 29 Sep 2017 08:02:54 +0000 (29 10:02 +0200) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Sun, 1 Oct 2017 03:03:35 +0000 (1 04:03 +0100) | ||
| tree | 648b7078ed5c0881ba64b2299418daeccdd30c08 | treesnapshot (tar.gz zip) |
| parent | 5a59a3a0ef0e546626a762d49dc06feaa204bab3 | commitdiff |
tipc: use only positive error codes in messages
In commit e3a77561e7d32 ("tipc: split up function tipc_msg_eval()"),
we have updated the function tipc_msg_lookup_dest() to set the error
codes to negative values at destination lookup failures. Thus when
the function sets the error code to -TIPC_ERR_NO_NAME, its inserted
into the 4 bit error field of the message header as 0xf instead of
TIPC_ERR_NO_NAME (1). The value 0xf is an unknown error code.
In this commit, we set only positive error code.
Fixes: e3a77561e7d32 ("tipc: split up function tipc_msg_eval()")
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
In commit e3a77561e7d32 ("tipc: split up function tipc_msg_eval()"),
we have updated the function tipc_msg_lookup_dest() to set the error
codes to negative values at destination lookup failures. Thus when
the function sets the error code to -TIPC_ERR_NO_NAME, its inserted
into the 4 bit error field of the message header as 0xf instead of
TIPC_ERR_NO_NAME (1). The value 0xf is an unknown error code.
In this commit, we set only positive error code.
Fixes: e3a77561e7d32 ("tipc: split up function tipc_msg_eval()")
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| net/tipc/msg.c | diffblobblamehistory |