| commit | 903efc553f738030a4ffa23fa03e7f329655c1c2 | |
| author | James Hogan <james.hogan@imgtec.com> | |
| Thu, 29 Aug 2013 11:10:51 +0000 (29 12:10 +0100) | ||
| committer | Mike Turquette <mturquette@linaro.org> | |
| Fri, 30 Aug 2013 19:52:01 +0000 (30 12:52 -0700) | ||
| tree | 3c0b612bf3889b07fd8b571ad5e35c9659ffb7c3 | treesnapshot (tar.gz zip) |
| parent | 08442ce993deeb15a070c14cc3f3459e87d111e0 | commitdiff |
clk: fix new_parent dereference before null check
Commit 71472c0 (clk: add support for clock reparent on set_rate) added a
dereference of the new_parent pointer in clk_reparent(), but as detected
by smatch clk_reparent() later checks whether new_parent is NULL.
The dereference was in order to clear the new parent's new_child pointer
to avoid duplicate POST_RATE_CHANGE notifications, so clearly isn't
necessary if the new parent is NULL, so move it inside the "if
(new_parent)" block.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
Commit 71472c0 (clk: add support for clock reparent on set_rate) added a
dereference of the new_parent pointer in clk_reparent(), but as detected
by smatch clk_reparent() later checks whether new_parent is NULL.
The dereference was in order to clear the new parent's new_child pointer
to avoid duplicate POST_RATE_CHANGE notifications, so clearly isn't
necessary if the new parent is NULL, so move it inside the "if
(new_parent)" block.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
| drivers/clk/clk.c | diffblobblamehistory |