| commit | 6bf69a1d6334bed776875c5ca852594ab4e5b209 | |
| author | Yan Markman <ymarkman@marvell.com> | |
| Mon, 25 Sep 2017 12:59:47 +0000 (25 14:59 +0200) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Thu, 28 Sep 2017 16:33:51 +0000 (28 09:33 -0700) | ||
| tree | 581254768cf0eaf49676b15eda140e38a3cb1600 | treesnapshot (tar.gz zip) |
| parent | aff3da39211105a42b2108b8af79bf8e16f670fd | commitdiff |
net: mvpp2: fix port list indexing
The private port_list array has a list of pointers to mvpp2_port
instances. This list is allocated given the number of ports enabled in
the device tree, but the pointers are set using the port-id property. If
on a single port is enabled, the port_list array will be of size 1, but
when registering the port, if its id is not 0 the driver will crash.
Other crashes were encountered in various situations.
This fixes the issue by using an index not equal to the value of the
port-id property.
Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit")
Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
Signed-off-by: Yan Markman <ymarkman@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
The private port_list array has a list of pointers to mvpp2_port
instances. This list is allocated given the number of ports enabled in
the device tree, but the pointers are set using the port-id property. If
on a single port is enabled, the port_list array will be of size 1, but
when registering the port, if its id is not 0 the driver will crash.
Other crashes were encountered in various situations.
This fixes the issue by using an index not equal to the value of the
port-id property.
Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit")
Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
Signed-off-by: Yan Markman <ymarkman@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/ethernet/marvell/mvpp2.c | diffblobblamehistory |